Repository navigation
Improve text element removal and fix test file name in workflow - #22
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the test suite to improve compatibility and reliability of matplotlib image comparisons and to clarify test file naming. The main change is adding a helper function to strip variable text from matplotlib figures before comparison.
Test infrastructure improvements:
test.pytotest_.pyand updated all references in documentation and CI configuration to use the new filename. This follows standards..github/workflows/pytest.yml) to run tests usingtest_.pyinstead oftest.py.Matplotlib image comparison enhancements:
strip_figure_textinbowtie/tests/helpers.pyto remove all text elements from matplotlib figures that can vary across versions (titles, labels, legends, etc.), ensuring more robust image comparison in tests.strip_figure_textbefore returning figures for comparison, in addition to the existingremove_text=Trueoption, for improved consistency.